Skip to content

Conversation

frostming
Copy link

Signed-off-by: Frost Ming [email protected]

This PR includes two fixes:

  • Skip directories when getting file from remote http to local
  • Unquote file names when creating local files

Copy link
Member

@martindurant martindurant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I have a comment about where best to insert it.

On the issue of unquote, do you have an example of the kind of thing you were seeing? This is essentially an HTTP href-> path translation? If yes, maybe it should be done at listing time?

@frostming
Copy link
Author

On the issue of unquote, do you have an example of the kind of thing you were seeing? This is essentially an HTTP href-> path translation? If yes, maybe it should be done at listing time?

I don't think so. ls()/find() might return absolute URLs, and URL encoding is reasonable here. It only needs to be unquoted when downloading to local paths(get)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants